Skip to content

Commit

Permalink
usb/storage: remove Filler member from struct bulk_cs_wrap
Browse files Browse the repository at this point in the history
As Alan Stern pointed out this member has nothing to do with the Command
Status Wrapper (CSW) as specified by the Universal Serial Bus Mass
Storage Class Bulk-Only Transport rev 1.0. It defines the structure
without the additional 18 filler bytes and defines the total size of the
struct to exactly 13 bytes. Larger responses should be dropped. All
in-tree users use a defines instead of sizeof() of this struct as far I
can tell.

Cc: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sebastian Andrzej Siewior authored and Greg Kroah-Hartman committed Feb 28, 2012
1 parent 775dafd commit 03892d5
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion include/linux/usb/storage.h
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ struct bulk_cs_wrap {
__u32 Tag; /* same as original command */
__le32 Residue; /* amount not transferred */
__u8 Status; /* see below */
__u8 Filler[18];
};

#define US_BULK_CS_WRAP_LEN 13
Expand Down

0 comments on commit 03892d5

Please sign in to comment.