Skip to content

Commit

Permalink
NFSv4.1: Always set the layout stateid if this is the first layoutget
Browse files Browse the repository at this point in the history
If the list of layout segments is empty, we must unconditionally set
the layout stateid.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Oct 2, 2012
1 parent 251ec41 commit 038d649
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions fs/nfs/pnfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ pnfs_set_layout_stateid(struct pnfs_layout_hdr *lo, const nfs4_stateid *new,

oldseq = be32_to_cpu(lo->plh_stateid.seqid);
newseq = be32_to_cpu(new->seqid);
if ((int)(newseq - oldseq) > 0) {
if (list_empty(&lo->plh_segs) || (int)(newseq - oldseq) > 0) {
nfs4_stateid_copy(&lo->plh_stateid, new);
if (update_barrier) {
u32 new_barrier = be32_to_cpu(new->seqid);
Expand Down Expand Up @@ -1181,6 +1181,10 @@ pnfs_layout_process(struct nfs4_layoutget *lgp)
dprintk("%s forget reply due to state\n", __func__);
goto out_forget_reply;
}

/* Done processing layoutget. Set the layout stateid */
pnfs_set_layout_stateid(lo, &res->stateid, false);

init_lseg(lo, lseg);
lseg->pls_range = res->range;
pnfs_get_lseg(lseg);
Expand All @@ -1191,8 +1195,6 @@ pnfs_layout_process(struct nfs4_layoutget *lgp)
set_bit(NFS_LAYOUT_ROC, &lo->plh_flags);
}

/* Done processing layoutget. Set the layout stateid */
pnfs_set_layout_stateid(lo, &res->stateid, false);
spin_unlock(&ino->i_lock);
return lseg;
out:
Expand Down

0 comments on commit 038d649

Please sign in to comment.