Skip to content

Commit

Permalink
perf_counter, x86: Fix kernel-space call-chains
Browse files Browse the repository at this point in the history
Kernel-space call-chains were trimmed at the first entry because
we never processed anything beyond the first stack context.

Allow the backtrace to jump from NMI to IRQ stack then to task stack
and finally user-space stack.

Also calculate the stack and bp variables correctly so that the
stack walker does not exit early.

We can get deep traces as a result, visible in perf report -D output:

0x32af0 [0xe0]: PERF_EVENT (IP, 5): 15134: 0xffffffff815225fd period: 1
... chain: u:2, k:22, nr:24
.....  0: 0xffffffff815225fd
.....  1: 0xffffffff810ac51c
.....  2: 0xffffffff81018e29
.....  3: 0xffffffff81523939
.....  4: 0xffffffff81524b8f
.....  5: 0xffffffff81524bd9
.....  6: 0xffffffff8105e498
.....  7: 0xffffffff8152315a
.....  8: 0xffffffff81522c3a
.....  9: 0xffffffff810d9b74
..... 10: 0xffffffff810dbeec
..... 11: 0xffffffff810dc3fb

This is a 22-entries kernel-space chain.

(We still only record reliable stack entries.)

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Ingo Molnar committed Jun 15, 2009
1 parent 5a6cec3 commit 038e836
Showing 1 changed file with 9 additions and 13 deletions.
22 changes: 9 additions & 13 deletions arch/x86/kernel/cpu/perf_counter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1575,8 +1575,8 @@ static void backtrace_warning(void *data, char *msg)

static int backtrace_stack(void *data, char *name)
{
/* Don't bother with IRQ stacks for now */
return -1;
/* Process all stacks: */
return 0;
}

static void backtrace_address(void *data, unsigned long addr, int reliable)
Expand All @@ -1594,33 +1594,29 @@ static const struct stacktrace_ops backtrace_ops = {
.address = backtrace_address,
};

#include "../dumpstack.h"

static void
perf_callchain_kernel(struct pt_regs *regs, struct perf_callchain_entry *entry)
{
unsigned long bp;
char *stack;
int nr = entry->nr;

callchain_store(entry, instruction_pointer(regs));
callchain_store(entry, regs->ip);

stack = ((char *)regs + sizeof(struct pt_regs));
#ifdef CONFIG_FRAME_POINTER
bp = frame_pointer(regs);
get_bp(bp);
#else
bp = 0;
#endif

dump_trace(NULL, regs, (void *)stack, bp, &backtrace_ops, entry);
dump_trace(NULL, regs, (void *)&stack, bp, &backtrace_ops, entry);

entry->kernel = entry->nr - nr;
}


struct stack_frame {
const void __user *next_fp;
unsigned long return_address;
};

static int copy_stack_frame(const void __user *fp, struct stack_frame *frame)
{
int ret;
Expand Down Expand Up @@ -1652,7 +1648,7 @@ perf_callchain_user(struct pt_regs *regs, struct perf_callchain_entry *entry)
callchain_store(entry, regs->ip);

while (entry->nr < MAX_STACK_DEPTH) {
frame.next_fp = NULL;
frame.next_frame = NULL;
frame.return_address = 0;

if (!copy_stack_frame(fp, &frame))
Expand All @@ -1662,7 +1658,7 @@ perf_callchain_user(struct pt_regs *regs, struct perf_callchain_entry *entry)
break;

callchain_store(entry, frame.return_address);
fp = frame.next_fp;
fp = frame.next_frame;
}

entry->user = entry->nr - nr;
Expand Down

0 comments on commit 038e836

Please sign in to comment.