Skip to content

Commit

Permalink
Staging: hv: storvsc: Disable clustering
Browse files Browse the repository at this point in the history
Disable clustering, since the host side on Hyper-V requires that
each I/O element not exceed the page size. As part of this
cleanup, get rid of the function to merge bvecs, as the primary
reason for this function was to avoid having an element exceed
the page size.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Dec 1, 2011
1 parent d426b2e commit 039db52
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions drivers/staging/hv/storvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -798,22 +798,13 @@ static int storvsc_device_alloc(struct scsi_device *sdevice)
return 0;
}

static int storvsc_merge_bvec(struct request_queue *q,
struct bvec_merge_data *bmd, struct bio_vec *bvec)
{
/* checking done by caller. */
return bvec->bv_len;
}

static int storvsc_device_configure(struct scsi_device *sdevice)
{
scsi_adjust_queue_depth(sdevice, MSG_SIMPLE_TAG,
STORVSC_MAX_IO_REQUESTS);

blk_queue_max_segment_size(sdevice->request_queue, PAGE_SIZE);

blk_queue_merge_bvec(sdevice->request_queue, storvsc_merge_bvec);

blk_queue_bounce_limit(sdevice->request_queue, BLK_BOUNCE_ANY);

return 0;
Expand Down Expand Up @@ -1375,14 +1366,7 @@ static struct scsi_host_template scsi_driver = {
/* no use setting to 0 since ll_blk_rw reset it to 1 */
/* currently 32 */
.sg_tablesize = MAX_MULTIPAGE_BUFFER_COUNT,
/*
* ENABLE_CLUSTERING allows mutiple physically contig bio_vecs to merge
* into 1 sg element. If set, we must limit the max_segment_size to
* PAGE_SIZE, otherwise we may get 1 sg element that represents
* multiple
*/
/* physically contig pfns (ie sg[x].length > PAGE_SIZE). */
.use_clustering = ENABLE_CLUSTERING,
.use_clustering = DISABLE_CLUSTERING,
/* Make sure we dont get a sg segment crosses a page boundary */
.dma_boundary = PAGE_SIZE-1,
};
Expand Down

0 comments on commit 039db52

Please sign in to comment.