Skip to content

Commit

Permalink
kernel/exit.c: Use list_for_each_entry(_safe) instead of list_for_eac…
Browse files Browse the repository at this point in the history
…h(_safe)

kernel/exit.c: Convert list_for_each(_safe) to
list_for_each_entry(_safe) in forget_original_parent(), exit_notify()
and do_wait()

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Matthias Kaehlcke authored and Linus Torvalds committed Oct 19, 2007
1 parent d473012 commit 03ff179
Showing 1 changed file with 6 additions and 13 deletions.
19 changes: 6 additions & 13 deletions kernel/exit.c
Original file line number Diff line number Diff line change
Expand Up @@ -669,8 +669,7 @@ reparent_thread(struct task_struct *p, struct task_struct *father, int traced)
static void
forget_original_parent(struct task_struct *father, struct list_head *to_release)
{
struct task_struct *p, *reaper = father;
struct list_head *_p, *_n;
struct task_struct *p, *n, *reaper = father;

do {
reaper = next_thread(reaper);
Expand All @@ -688,9 +687,8 @@ forget_original_parent(struct task_struct *father, struct list_head *to_release)
*
* Search them and reparent children.
*/
list_for_each_safe(_p, _n, &father->children) {
list_for_each_entry_safe(p, n, &father->children, sibling) {
int ptrace;
p = list_entry(_p, struct task_struct, sibling);

ptrace = p->ptrace;

Expand Down Expand Up @@ -718,8 +716,7 @@ forget_original_parent(struct task_struct *father, struct list_head *to_release)
if (unlikely(ptrace && p->exit_state == EXIT_ZOMBIE && p->exit_signal == -1))
list_add(&p->ptrace_list, to_release);
}
list_for_each_safe(_p, _n, &father->ptrace_children) {
p = list_entry(_p, struct task_struct, ptrace_list);
list_for_each_entry_safe(p, n, &father->ptrace_children, ptrace_list) {
p->real_parent = reaper;
reparent_thread(p, father, 1);
}
Expand Down Expand Up @@ -1518,12 +1515,9 @@ static long do_wait(pid_t pid, int options, struct siginfo __user *infop,
tsk = current;
do {
struct task_struct *p;
struct list_head *_p;
int ret;

list_for_each(_p,&tsk->children) {
p = list_entry(_p, struct task_struct, sibling);

list_for_each_entry(p, &tsk->children, sibling) {
ret = eligible_child(pid, options, p);
if (!ret)
continue;
Expand Down Expand Up @@ -1605,9 +1599,8 @@ static long do_wait(pid_t pid, int options, struct siginfo __user *infop,
}
}
if (!flag) {
list_for_each(_p, &tsk->ptrace_children) {
p = list_entry(_p, struct task_struct,
ptrace_list);
list_for_each_entry(p, &tsk->ptrace_children,
ptrace_list) {
if (!eligible_child(pid, options, p))
continue;
flag = 1;
Expand Down

0 comments on commit 03ff179

Please sign in to comment.