Skip to content

Commit

Permalink
ath9k/debug: fixup the return codes
Browse files Browse the repository at this point in the history
Changed -EINVAL to -EFAULT if copy_to_user() failed.
Changed 0 to -ENOMEM if allocations failed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Dan Carpenter authored and John W. Linville committed Jun 2, 2010
1 parent 2b87f3a commit 0423606
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/net/wireless/ath/ath9k/debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ static ssize_t write_file_debug(struct file *file, const char __user *user_buf,

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len))
return -EINVAL;
return -EFAULT;

buf[len] = '\0';
if (strict_strtoul(buf, 0, &mask))
Expand Down Expand Up @@ -101,7 +101,7 @@ static ssize_t write_file_tx_chainmask(struct file *file, const char __user *use

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len))
return -EINVAL;
return -EFAULT;

buf[len] = '\0';
if (strict_strtoul(buf, 0, &mask))
Expand Down Expand Up @@ -143,7 +143,7 @@ static ssize_t write_file_rx_chainmask(struct file *file, const char __user *use

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len))
return -EINVAL;
return -EFAULT;

buf[len] = '\0';
if (strict_strtoul(buf, 0, &mask))
Expand Down Expand Up @@ -176,7 +176,7 @@ static ssize_t read_file_dma(struct file *file, char __user *user_buf,

buf = kmalloc(DMA_BUF_LEN, GFP_KERNEL);
if (!buf)
return 0;
return -ENOMEM;

ath9k_ps_wakeup(sc);

Expand Down Expand Up @@ -411,7 +411,7 @@ static ssize_t read_file_rcstat(struct file *file, char __user *user_buf,
max = 80 + sc->cur_rate_table->rate_cnt * 1024 + 1;
buf = kmalloc(max, GFP_KERNEL);
if (buf == NULL)
return 0;
return -ENOMEM;

len += sprintf(buf, "%6s %6s %6s "
"%10s %10s %10s %10s\n",
Expand Down Expand Up @@ -646,7 +646,7 @@ static ssize_t read_file_xmit(struct file *file, char __user *user_buf,

buf = kzalloc(size, GFP_KERNEL);
if (buf == NULL)
return 0;
return -ENOMEM;

len += sprintf(buf, "%30s %10s%10s%10s\n\n", "BE", "BK", "VI", "VO");

Expand Down Expand Up @@ -719,7 +719,7 @@ static ssize_t read_file_recv(struct file *file, char __user *user_buf,

buf = kzalloc(size, GFP_KERNEL);
if (buf == NULL)
return 0;
return -ENOMEM;

len += snprintf(buf + len, size - len,
"%18s : %10u\n", "CRC ERR",
Expand Down Expand Up @@ -838,7 +838,7 @@ static ssize_t write_file_regidx(struct file *file, const char __user *user_buf,

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len))
return -EINVAL;
return -EFAULT;

buf[len] = '\0';
if (strict_strtoul(buf, 0, &regidx))
Expand Down Expand Up @@ -880,7 +880,7 @@ static ssize_t write_file_regval(struct file *file, const char __user *user_buf,

len = min(count, sizeof(buf) - 1);
if (copy_from_user(buf, user_buf, len))
return -EINVAL;
return -EFAULT;

buf[len] = '\0';
if (strict_strtoul(buf, 0, &regval))
Expand Down

0 comments on commit 0423606

Please sign in to comment.