Skip to content

Commit

Permalink
ARM: EXYNOS: Use cpuidle_register
Browse files Browse the repository at this point in the history
Use the cpuidle generic function 'cpuidle_register'. That saves us
from some extra lines of code and unneeded variables.

A side effect of this change is a bug fix where before the cpuidle
driver was registered for each_online_cpu and now it is for
each_possible_cpu.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Daniel Lezcano authored and Kukjin Kim committed May 25, 2014
1 parent 53af16a commit 043c86b
Showing 1 changed file with 2 additions and 16 deletions.
18 changes: 2 additions & 16 deletions arch/arm/mach-exynos/cpuidle.c
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@

#define S5P_CHECK_AFTR 0xFCBA0D10

static DEFINE_PER_CPU(struct cpuidle_device, exynos4_cpuidle_device);

/* Ext-GIC nIRQ/nFIQ is the only wakeup source in AFTR */
static void exynos4_set_wakeupmask(void)
{
Expand Down Expand Up @@ -161,29 +159,17 @@ static struct cpuidle_driver exynos4_idle_driver = {

static int exynos_cpuidle_probe(struct platform_device *pdev)
{
int cpu_id, ret;
struct cpuidle_device *device;
int ret;

if (soc_is_exynos5440())
exynos4_idle_driver.state_count = 1;

ret = cpuidle_register_driver(&exynos4_idle_driver);
ret = cpuidle_register(&exynos4_idle_driver, NULL);
if (ret) {
dev_err(&pdev->dev, "failed to register cpuidle driver\n");
return ret;
}

for_each_online_cpu(cpu_id) {
device = &per_cpu(exynos4_cpuidle_device, cpu_id);
device->cpu = cpu_id;

ret = cpuidle_register_device(device);
if (ret) {
dev_err(&pdev->dev, "failed to register cpuidle device\n");
return ret;
}
}

return 0;
}

Expand Down

0 comments on commit 043c86b

Please sign in to comment.