Skip to content

Commit

Permalink
Thermal/cpu_cooling: Return directly for the cpu out of allowed_cpus …
Browse files Browse the repository at this point in the history
…in the cpufreq_thermal_notifier()

cpufreq_thermal_notifier() is to change the cpu's cpufreq in the allowed_cpus mask
when associated thermal-cpufreq cdev's cooling state is changed. It's a cpufreq policy
notifier handler and it will be triggered even if those cpus out of allowed_cpus has
changed freq policy.

cpufreq_thermal_notifier() checks the policy->cpu. If it belongs to allowed_cpus,
change max_freq(default to 0) to the desire cpufreq value and pass 0 and max_freq
to cpufreq_verify_within_limits() as cpufreq scope. But if not, do nothing and
max_freq will remain 0. This will cause the cpufreq scope to become 0~0. This
is not right. This patch is to return directly after finding cpu not belonging
to allowed_cpus.

Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
  • Loading branch information
Lan Tianyu authored and Zhang Rui committed Aug 15, 2013
1 parent 584d88b commit 044d5c2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/thermal/cpu_cooling.c
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ static int cpufreq_thermal_notifier(struct notifier_block *nb,

if (cpumask_test_cpu(policy->cpu, &notify_device->allowed_cpus))
max_freq = notify_device->cpufreq_val;
else
return 0;

/* Never exceed user_policy.max */
if (max_freq > policy->user_policy.max)
Expand Down

0 comments on commit 044d5c2

Please sign in to comment.