Skip to content

Commit

Permalink
spi: qup: Fix order of spi_register_master
Browse files Browse the repository at this point in the history
This patch moves the devm_spi_register_master below the initialization of the
runtime_pm.  If done in the wrong order, the spi_register_master fails if any
probed slave devices issue SPI transactions.

Signed-off-by: Andy Gross <agross@codeaurora.org>
Acked-by: Ivan T. Ivanov <iivanov@mm-sol.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Andy Gross authored and Mark Brown committed Jun 21, 2014
1 parent 7171511 commit 045c243
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions drivers/spi/spi-qup.c
Original file line number Diff line number Diff line change
Expand Up @@ -640,16 +640,19 @@ static int spi_qup_probe(struct platform_device *pdev)
if (ret)
goto error;

ret = devm_spi_register_master(dev, master);
if (ret)
goto error;

pm_runtime_set_autosuspend_delay(dev, MSEC_PER_SEC);
pm_runtime_use_autosuspend(dev);
pm_runtime_set_active(dev);
pm_runtime_enable(dev);

ret = devm_spi_register_master(dev, master);
if (ret)
goto disable_pm;

return 0;

disable_pm:
pm_runtime_disable(&pdev->dev);
error:
clk_disable_unprepare(cclk);
clk_disable_unprepare(iclk);
Expand Down

0 comments on commit 045c243

Please sign in to comment.