Skip to content

Commit

Permalink
[PATCH] CRIS: turn local_save_flags() + local_irq_disable() into loca…
Browse files Browse the repository at this point in the history
…l_irq_save() in headers

Various headers for CRIS architecture contain local_irq_disable() after
local_save_flags().  Turn it into local_irq_save().

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Mikael Starvik <starvik@axis.com>

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Kosina authored and Linus Torvalds committed Feb 11, 2007
1 parent 7c101b7 commit 047c7c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
9 changes: 3 additions & 6 deletions include/asm-cris/semaphore-helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ static inline int waking_non_zero(struct semaphore *sem)
unsigned long flags;
int ret = 0;

local_save_flags(flags);
local_irq_disable();
local_irq_save(flags);
if (read(&sem->waking) > 0) {
dec(&sem->waking);
ret = 1;
Expand All @@ -46,8 +45,7 @@ static inline int waking_non_zero_interruptible(struct semaphore *sem,
int ret = 0;
unsigned long flags;

local_save_flags(flags);
local_irq_disable();
local_irq_save(flags);
if (read(&sem->waking) > 0) {
dec(&sem->waking);
ret = 1;
Expand All @@ -64,8 +62,7 @@ static inline int waking_non_zero_trylock(struct semaphore *sem)
int ret = 1;
unsigned long flags;

local_save_flags(flags);
local_irq_disable();
local_irq_save(flags);
if (read(&sem->waking) <= 0)
inc(&sem->count);
else {
Expand Down
3 changes: 1 addition & 2 deletions include/asm-cris/system.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ static inline unsigned long __xchg(unsigned long x, volatile void * ptr, int siz
/* since Etrax doesn't have any atomic xchg instructions, we need to disable
irq's (if enabled) and do it with move.d's */
unsigned long flags,temp;
local_save_flags(flags); /* save flags, including irq enable bit */
local_irq_disable(); /* shut off irq's */
local_irq_save(flags); /* save flags, including irq enable bit and shut off irqs */
switch (size) {
case 1:
*((unsigned char *)&temp) = x;
Expand Down

0 comments on commit 047c7c4

Please sign in to comment.