Skip to content

Commit

Permalink
[media] gspca - stv06xx: Fix a regression with the bridge/sensor vv6410
Browse files Browse the repository at this point in the history
Setting the H and V flip controls at webcam connection time prevents
the webcam to work correctly.
This patch checks if the webcam is streaming before setting the flips.
It does not set the flips (nor other controls) at webcam start time.

Tested-by: Philippe ROUBACH <philippe.roubach@free.fr>
Signed-off-by: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Jean-François Moine authored and Mauro Carvalho Chehab committed Dec 21, 2012
1 parent 1c9f5bd commit 0488112
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/media/usb/gspca/stv06xx/stv06xx_vv6410.c
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,13 @@ static int vv6410_s_ctrl(struct v4l2_ctrl *ctrl)

switch (ctrl->id) {
case V4L2_CID_HFLIP:
if (!gspca_dev->streaming)
return 0;
err = vv6410_set_hflip(gspca_dev, ctrl->val);
break;
case V4L2_CID_VFLIP:
if (!gspca_dev->streaming)
return 0;
err = vv6410_set_vflip(gspca_dev, ctrl->val);
break;
case V4L2_CID_GAIN:
Expand Down

0 comments on commit 0488112

Please sign in to comment.