Skip to content

Commit

Permalink
blktrace: use BLKTRACE_BDEV_SIZE as the name size for setup structure
Browse files Browse the repository at this point in the history
Define as 32, which is is what BDEVNAME_SIZE is/was as well. This keeps
the user interface the same and gets rid of the difference between
kernel and user api here.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Jens Axboe committed Oct 9, 2008
1 parent ef9e3fa commit 0497b34
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
3 changes: 2 additions & 1 deletion block/blktrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,8 @@ int do_blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (!buts->buf_size || !buts->buf_nr)
return -EINVAL;

strcpy(buts->name, name);
strncpy(buts->name, name, BLKTRACE_BDEV_SIZE);
buts->name[BLKTRACE_BDEV_SIZE - 1] = '\0';

/*
* some device names have larger paths - convert the slashes
Expand Down
8 changes: 3 additions & 5 deletions include/linux/blktrace_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,15 +122,13 @@ enum {
Blktrace_stopped,
};

#define BLKTRACE_BDEV_SIZE 32

/*
* User setup structure passed with BLKTRACESTART
*/
struct blk_user_trace_setup {
#ifdef __KERNEL__
char name[BDEVNAME_SIZE]; /* output */
#else
char name[32]; /* output */
#endif
char name[BLKTRACE_BDEV_SIZE]; /* output */
__u16 act_mask; /* input */
__u32 buf_size; /* input */
__u32 buf_nr; /* input */
Expand Down

0 comments on commit 0497b34

Please sign in to comment.