Skip to content

Commit

Permalink
mfd: Fix incorrect kfree(i2c) in tps6507x i2c_driver probe
Browse files Browse the repository at this point in the history
The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Axel Lin authored and Samuel Ortiz committed Aug 12, 2010
1 parent c6c1933 commit 04a0642
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/mfd/tps6507x.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c,
int ret = 0;

tps6507x = kzalloc(sizeof(struct tps6507x_dev), GFP_KERNEL);
if (tps6507x == NULL) {
kfree(i2c);
if (tps6507x == NULL)
return -ENOMEM;
}

i2c_set_clientdata(i2c, tps6507x);
tps6507x->dev = &i2c->dev;
Expand Down

0 comments on commit 04a0642

Please sign in to comment.