Skip to content

Commit

Permalink
sparc: kernel/sbus.c: fix memory leakage
Browse files Browse the repository at this point in the history
The variable iommu and strbuf are not freed properly if it goes to error.

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Reviewed-by: Richard Mortimer <richm@oldelvet.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cong Ding authored and David S. Miller committed Jan 21, 2013
1 parent 9a92841 commit 04cef49
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/sparc/kernel/sbus.c
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
regs = pr->phys_addr;

iommu = kzalloc(sizeof(*iommu), GFP_ATOMIC);
if (!iommu)
goto fatal_memory_error;
strbuf = kzalloc(sizeof(*strbuf), GFP_ATOMIC);
if (!strbuf)
if (!iommu || !strbuf)
goto fatal_memory_error;

op->dev.archdata.iommu = iommu;
Expand Down Expand Up @@ -656,6 +654,8 @@ static void __init sbus_iommu_init(struct platform_device *op)
return;

fatal_memory_error:
kfree(iommu);
kfree(strbuf);
prom_printf("sbus_iommu_init: Fatal memory allocation error.\n");
}

Expand Down

0 comments on commit 04cef49

Please sign in to comment.