Skip to content

Commit

Permalink
mfd: Fix off-by-one value range checking for tps65910_i2c_write
Browse files Browse the repository at this point in the history
If bytes == (TPS65910_MAX_REGISTER + 1), we have a buffer overflow when
doing memcpy(&msg[1], src, bytes).

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
  • Loading branch information
Axel Lin authored and Liam Girdwood committed May 27, 2011
1 parent 4aa922c commit 0514e9a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mfd/tps65910.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ static int tps65910_i2c_write(struct tps65910 *tps65910, u8 reg,
u8 msg[TPS65910_MAX_REGISTER + 1];
int ret;

if (bytes > (TPS65910_MAX_REGISTER + 1))
if (bytes > TPS65910_MAX_REGISTER)
return -EINVAL;

msg[0] = reg;
Expand Down

0 comments on commit 0514e9a

Please sign in to comment.