Skip to content

Commit

Permalink
xhci: Fix a logical vs bitwise AND bug
Browse files Browse the repository at this point in the history
The intent was to test whether the flag was set.

This patch should be backported to stable kernels as old as 3.0, since
it fixes a bug in commit e95829f "xhci:
Switch PPT ports to EHCI on shutdown.", which was marked for stable.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: stable@vger.kernel.org
  • Loading branch information
Dan Carpenter authored and Sarah Sharp committed Sep 5, 2012
1 parent a96874a commit 052c7f9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/host/xhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ void xhci_shutdown(struct usb_hcd *hcd)
{
struct xhci_hcd *xhci = hcd_to_xhci(hcd);

if (xhci->quirks && XHCI_SPURIOUS_REBOOT)
if (xhci->quirks & XHCI_SPURIOUS_REBOOT)
usb_disable_xhci_ports(to_pci_dev(hcd->self.controller));

spin_lock_irq(&xhci->lock);
Expand Down

0 comments on commit 052c7f9

Please sign in to comment.