Skip to content

Commit

Permalink
[MIPS] Remove redundant r4k_blast_icache() calls
Browse files Browse the repository at this point in the history
r4k_flush_cache_all() and r4k_flush_cache_mm() case: these are noop if
the CPU did not have dc_aliases.  It would mean we do not need to care
about icache here.

r4k_flush_cache_range case: if r4k_flush_cache_mm() did not need to
care about icache, it would be same for this function.

Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Atsushi Nemoto authored and Ralf Baechle committed Nov 30, 2006
1 parent e567988 commit 0550d9d
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions arch/mips/mm/c-r4k.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,6 @@ static void __init r4k_blast_scache_setup(void)
static inline void local_r4k_flush_cache_all(void * args)
{
r4k_blast_dcache();
r4k_blast_icache();
}

static void r4k_flush_cache_all(void)
Expand Down Expand Up @@ -359,21 +358,19 @@ static void r4k___flush_cache_all(void)
static inline void local_r4k_flush_cache_range(void * args)
{
struct vm_area_struct *vma = args;
int exec;

if (!(cpu_context(smp_processor_id(), vma->vm_mm)))
return;

exec = vma->vm_flags & VM_EXEC;
if (cpu_has_dc_aliases || exec)
r4k_blast_dcache();
if (exec)
r4k_blast_icache();
r4k_blast_dcache();
}

static void r4k_flush_cache_range(struct vm_area_struct *vma,
unsigned long start, unsigned long end)
{
if (!cpu_has_dc_aliases)
return;

r4k_on_each_cpu(local_r4k_flush_cache_range, vma, 1, 1);
}

Expand All @@ -385,7 +382,6 @@ static inline void local_r4k_flush_cache_mm(void * args)
return;

r4k_blast_dcache();
r4k_blast_icache();

/*
* Kludge alert. For obscure reasons R4000SC and R4400SC go nuts if we
Expand Down

0 comments on commit 0550d9d

Please sign in to comment.