---

yaml --- r: 73347 b: refs/heads/master c: fffe487 h: refs/heads/master i: 73345: fe189c2 73343: 0e75578 v: v3
git-mirror · Nov 8, 2007 · 0562b81 · 0562b81
1 parent e9d13ad
commit 0562b81
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 8ec680e4c3ec818efd1652f15199ed1c216ab550
+refs/heads/master: fffe487d59ba4017c7c62b06667ca4a226cee651
diff --git a/trunk/drivers/block/pktcdvd.c b/trunk/drivers/block/pktcdvd.c
@@ -358,10 +358,19 @@ static ssize_t class_pktcdvd_store_add(struct class *c, const char *buf,
 					size_t count)
 {
 	unsigned int major, minor;
+
 	if (sscanf(buf, "%u:%u", &major, &minor) == 2) {
+		/* pkt_setup_dev() expects caller to hold reference to self */
+		if (!try_module_get(THIS_MODULE))
+			return -ENODEV;
+
 		pkt_setup_dev(MKDEV(major, minor), NULL);
+
+		module_put(THIS_MODULE);
+
 		return count;
 	}
+
 	return -EINVAL;
 }