Skip to content

Commit

Permalink
mac80211: fix powersave
Browse files Browse the repository at this point in the history
Some of the recent MLME rework I did broke powersave
because the ps_sdata isn't assigned at the right time,
and the work item wasn't removed from the list before
calling ieee80211_recalc_ps(). To be more specific,
this broke the case where you'd enabled PS before
associating, either automatically or with iwconfig.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Johannes Berg authored and John W. Linville committed Aug 4, 2009
1 parent b7cfc5b commit 056508d
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions net/mac80211/mlme.c
Original file line number Diff line number Diff line change
Expand Up @@ -916,12 +916,9 @@ static void ieee80211_set_associated(struct ieee80211_sub_if_data *sdata,

ieee80211_bss_info_change_notify(sdata, bss_info_changed);

/* will be same as sdata */
if (local->ps_sdata) {
mutex_lock(&local->iflist_mtx);
ieee80211_recalc_ps(local, -1);
mutex_unlock(&local->iflist_mtx);
}
mutex_lock(&local->iflist_mtx);
ieee80211_recalc_ps(local, -1);
mutex_unlock(&local->iflist_mtx);

netif_tx_start_all_queues(sdata->dev);
netif_carrier_on(sdata->dev);
Expand Down Expand Up @@ -1569,6 +1566,9 @@ ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
wk->bss->cbss.bssid,
ap_ht_cap_flags);

/* delete work item -- must be before set_associated for PS */
list_del(&wk->list);

/* set AID and assoc capability,
* ieee80211_set_associated() will tell the driver */
bss_conf->aid = aid;
Expand All @@ -1582,7 +1582,6 @@ ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
ieee80211_sta_rx_notify(sdata, (struct ieee80211_hdr *)mgmt);
mod_beacon_timer(sdata);

list_del(&wk->list);
kfree(wk);
return RX_MGMT_CFG80211_ASSOC;
}
Expand Down

0 comments on commit 056508d

Please sign in to comment.