Skip to content

Commit

Permalink
ide: unexport ide_set_xfer_rate() (v2)
Browse files Browse the repository at this point in the history
In cmd64x, siimage and scc_pata drivers:
* don't set drive->init_speed as it should be already
  set by successful execution of ide_set_xfer_rate()
* use hwif->speedproc functions directly

Above changes allows removal of EXPORT_SYMBOL_GPL(ide_set_xfer_rate).

v2:
* updated for scc_pata driver

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
  • Loading branch information
Bartlomiej Zolnierkiewicz committed Feb 17, 2007
1 parent c94964a commit 056a697
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 15 deletions.
2 changes: 0 additions & 2 deletions drivers/ide/ide-lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,8 +459,6 @@ int ide_set_xfer_rate(ide_drive_t *drive, u8 rate)
return -1;
}

EXPORT_SYMBOL_GPL(ide_set_xfer_rate);

static void ide_dump_opcode(ide_drive_t *drive)
{
struct request *rq;
Expand Down
7 changes: 2 additions & 5 deletions drivers/ide/pci/cmd64x.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,11 +466,8 @@ static int config_chipset_for_dma (ide_drive_t *drive)
if (!speed)
return 0;

if(ide_set_xfer_rate(drive, speed))
return 0;

if (!drive->init_speed)
drive->init_speed = speed;
if (cmd64x_tune_chipset(drive, speed))
return 0;

return ide_dma_enable(drive);
}
Expand Down
5 changes: 1 addition & 4 deletions drivers/ide/pci/siimage.c
Original file line number Diff line number Diff line change
Expand Up @@ -396,12 +396,9 @@ static int config_chipset_for_dma (ide_drive_t *drive)
if (!speed)
return 0;

if (ide_set_xfer_rate(drive, speed))
if (siimage_tune_chipset(drive, speed))
return 0;

if (!drive->init_speed)
drive->init_speed = speed;

return ide_dma_enable(drive);
}

Expand Down
5 changes: 1 addition & 4 deletions drivers/ide/ppc/scc_pata.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,12 +363,9 @@ static int scc_config_chipset_for_dma(ide_drive_t *drive)
if (!speed)
return 0;

if (ide_set_xfer_rate(drive, speed))
if (scc_tune_chipset(drive, speed))
return 0;

if (!drive->init_speed)
drive->init_speed = speed;

return ide_dma_enable(drive);
}

Expand Down

0 comments on commit 056a697

Please sign in to comment.