Skip to content

Commit

Permalink
mfd: tps65910: Fix wrong ack_base register
Browse files Browse the repository at this point in the history
The interrupt status registers of TPS65910/1 should be cleared
when the associated interrupt event occurs.
This work is done in the regmap irq thread - using 'ack_base' register.
The ACK registers should be fixed as status register, not mask registers.

This patch fixes the infinite interrupt event problem by clearing
interrupt status registers.

Tested on the AM3517 Craneboard.

Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Kim, Milo authored and Samuel Ortiz committed Nov 30, 2012
1 parent 0e5fca8 commit 0582c0f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mfd/tps65910.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ static struct regmap_irq_chip tps65911_irq_chip = {
.irq_reg_stride = 2,
.status_base = TPS65910_INT_STS,
.mask_base = TPS65910_INT_MSK,
.ack_base = TPS65910_INT_MSK,
.ack_base = TPS65910_INT_STS,
};

static struct regmap_irq_chip tps65910_irq_chip = {
Expand All @@ -222,7 +222,7 @@ static struct regmap_irq_chip tps65910_irq_chip = {
.irq_reg_stride = 2,
.status_base = TPS65910_INT_STS,
.mask_base = TPS65910_INT_MSK,
.ack_base = TPS65910_INT_MSK,
.ack_base = TPS65910_INT_STS,
};

static int tps65910_irq_init(struct tps65910 *tps65910, int irq,
Expand Down

0 comments on commit 0582c0f

Please sign in to comment.