Skip to content

Commit

Permalink
[media] exynos4-is: Correct clock properties description at the DT bi…
Browse files Browse the repository at this point in the history
…nding documentation

The 'camera' DT node needs to have sclk_cam0/1 and pxl_async0/1 clocks
specified, while 'fimc' nodes should have only "fimc" and "sclk_fimc".
"mux" and "parent" are leftovers from early versions of patches adding
DT support, when the IP bus clock parent clock was being set by the
driver. A better solution is needed to have e.g. clocks driver setting
all required parent clocks, before clock consumers start using the
clocks. Currently this binding doesn't describe parent clocks setup,
it needs to be specified and handled somewhere else.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Sylwester Nawrocki authored and Mauro Carvalho Chehab committed Apr 4, 2013
1 parent b3d8b55 commit 05a70a4
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions Documentation/devicetree/bindings/media/samsung-fimc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ Required properties:

- compatible : must be "samsung,fimc", "simple-bus"
- clocks : list of clock specifiers, corresponding to entries in
clock-names property;
- clock-names : must contain "fimc", "sclk_fimc" entries, matching entries
in the clocks property.
the clock-names property;
- clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0",
"pxl_async1" entries, matching entries in the clocks property.

The pinctrl bindings defined in ../pinctrl/pinctrl-bindings.txt must be used
to define a required pinctrl state named "default" and optional pinctrl states:
Expand All @@ -32,7 +32,6 @@ way around.

The 'camera' node must include at least one 'fimc' child node.


'fimc' device nodes
-------------------

Expand All @@ -44,8 +43,7 @@ Required properties:
- interrupts: should contain FIMC interrupt;
- clocks: list of clock specifiers, must contain an entry for each required
entry in clock-names;
- clock-names: must include "fimc", "sclk_fimc", "mux" entries and optionally
"parent" entry.
- clock-names: must contain "fimc", "sclk_fimc" entries.
- samsung,pix-limits: an array of maximum supported image sizes in pixels, for
details refer to Table 2-1 in the S5PV210 SoC User Manual; The meaning of
each cell is as follows:
Expand Down

0 comments on commit 05a70a4

Please sign in to comment.