Skip to content

Commit

Permalink
ACPI: drop unnecessary local variable from acpi_system_write_wakeup_d…
Browse files Browse the repository at this point in the history
…evice()

The LEN variable is unsigned, therefore checking whether it is less than 0 is
useless. Also drop the LEN variable, since the COUNT parameter can be used
instead.

[rjw: Changed the subject.]
Signed-off-by: Cyril Roelandt <tipecaml@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Cyril Roelandt authored and Rafael J. Wysocki committed Nov 22, 2012
1 parent 66fd383 commit 05bce79
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions drivers/acpi/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,16 +362,13 @@ acpi_system_write_wakeup_device(struct file *file,
struct list_head *node, *next;
char strbuf[5];
char str[5] = "";
unsigned int len = count;

if (len > 4)
len = 4;
if (len < 0)
return -EFAULT;
if (count > 4)
count = 4;

if (copy_from_user(strbuf, buffer, len))
if (copy_from_user(strbuf, buffer, count))
return -EFAULT;
strbuf[len] = '\0';
strbuf[count] = '\0';
sscanf(strbuf, "%s", str);

mutex_lock(&acpi_device_lock);
Expand Down

0 comments on commit 05bce79

Please sign in to comment.