Skip to content

Commit

Permalink
power: convert to idr_alloc()
Browse files Browse the repository at this point in the history
Convert to the much saner new idr interface.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Anton Vorontsov <cbou@mail.ru>
Cc: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Tejun Heo authored and Linus Torvalds committed Feb 28, 2013
1 parent 2fa532c commit 05e2cef
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 21 deletions.
11 changes: 3 additions & 8 deletions drivers/power/bq2415x_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -1515,16 +1515,11 @@ static int bq2415x_probe(struct i2c_client *client,
}

/* Get new ID for the new device */
ret = idr_pre_get(&bq2415x_id, GFP_KERNEL);
if (ret == 0)
return -ENOMEM;

mutex_lock(&bq2415x_id_mutex);
ret = idr_get_new(&bq2415x_id, client, &num);
num = idr_alloc(&bq2415x_id, client, 0, 0, GFP_KERNEL);
mutex_unlock(&bq2415x_id_mutex);

if (ret < 0)
return ret;
if (num < 0)
return num;

name = kasprintf(GFP_KERNEL, "%s-%d", id->name, num);
if (!name) {
Expand Down
9 changes: 3 additions & 6 deletions drivers/power/bq27x00_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -791,14 +791,11 @@ static int bq27x00_battery_probe(struct i2c_client *client,
int retval = 0;

/* Get new ID for the new battery device */
retval = idr_pre_get(&battery_id, GFP_KERNEL);
if (retval == 0)
return -ENOMEM;
mutex_lock(&battery_mutex);
retval = idr_get_new(&battery_id, client, &num);
num = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
mutex_unlock(&battery_mutex);
if (retval < 0)
return retval;
if (num < 0)
return num;

name = kasprintf(GFP_KERNEL, "%s-%d", id->name, num);
if (!name) {
Expand Down
9 changes: 2 additions & 7 deletions drivers/power/ds2782_battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,17 +395,12 @@ static int ds278x_battery_probe(struct i2c_client *client,
}

/* Get an ID for this battery */
ret = idr_pre_get(&battery_id, GFP_KERNEL);
if (ret == 0) {
ret = -ENOMEM;
goto fail_id;
}

mutex_lock(&battery_lock);
ret = idr_get_new(&battery_id, client, &num);
ret = idr_alloc(&battery_id, client, 0, 0, GFP_KERNEL);
mutex_unlock(&battery_lock);
if (ret < 0)
goto fail_id;
num = ret;

info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info) {
Expand Down

0 comments on commit 05e2cef

Please sign in to comment.