Skip to content

Commit

Permalink
net: Create and use new helper, neigh_output().
Browse files Browse the repository at this point in the history
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jul 17, 2011
1 parent a292829 commit 05e3aa0
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 14 deletions.
9 changes: 9 additions & 0 deletions include/net/neighbour.h
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,15 @@ static inline int neigh_hh_output(struct hh_cache *hh, struct sk_buff *skb)
return hh->hh_output(skb);
}

static inline int neigh_output(struct neighbour *n, struct sk_buff *skb)
{
struct hh_cache *hh = &n->hh;
if (hh->hh_len)
return neigh_hh_output(hh, skb);
else
return n->output(skb);
}

static inline struct neighbour *
__neigh_lookup(struct neigh_table *tbl, const void *pkey, struct net_device *dev, int creat)
{
Expand Down
10 changes: 3 additions & 7 deletions net/ipv4/ip_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,9 @@ static inline int ip_finish_output2(struct sk_buff *skb)
}

neigh = dst->neighbour;
if (neigh) {
struct hh_cache *hh = &neigh->hh;
if (hh->hh_len)
return neigh_hh_output(hh, skb);
else
return neigh->output(skb);
}
if (neigh)
return neigh_output(neigh, skb);

if (net_ratelimit())
printk(KERN_DEBUG "ip_finish_output2: No header cache and no neighbour!\n");
kfree_skb(skb);
Expand Down
10 changes: 3 additions & 7 deletions net/ipv6/ip6_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,9 @@ static int ip6_finish_output2(struct sk_buff *skb)
}

neigh = dst->neighbour;
if (neigh) {
struct hh_cache *hh = &neigh->hh;
if (hh->hh_len)
return neigh_hh_output(hh, skb);
else
return neigh->output(skb);
}
if (neigh)
return neigh_output(neigh, skb);

IP6_INC_STATS_BH(dev_net(dst->dev),
ip6_dst_idev(dst), IPSTATS_MIB_OUTNOROUTES);
kfree_skb(skb);
Expand Down

0 comments on commit 05e3aa0

Please sign in to comment.