Skip to content

Commit

Permalink
[SCSI] libfc: remove tgt_flags from fc_fcp_pkt struct
Browse files Browse the repository at this point in the history
We can easily remove the tgt_flags from fc_fcp_pkt struct
and use rpriv->tgt_flags directly where needed.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
john fastabend authored and James Bottomley committed Dec 21, 2010
1 parent e0883a3 commit 05fee64
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
5 changes: 2 additions & 3 deletions drivers/scsi/libfc/fc_fcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1150,8 +1150,9 @@ static int fc_fcp_cmd_send(struct fc_lport *lport, struct fc_fcp_pkt *fsp,

setup_timer(&fsp->timer, fc_fcp_timeout, (unsigned long)fsp);

if (fsp->tgt_flags & FC_RP_FLAGS_REC_SUPPORTED)
if (rpriv->flags & FC_RP_FLAGS_REC_SUPPORTED)
fc_fcp_timer_set(fsp, rec_tov);

unlock:
fc_fcp_unlock_pkt(fsp);
return rc;
Expand Down Expand Up @@ -1867,8 +1868,6 @@ static int fc_queuecommand_lck(struct scsi_cmnd *sc_cmd, void (*done)(struct scs
}
put_cpu();

fsp->tgt_flags = rpriv->flags;

init_timer(&fsp->timer);
fsp->timer.data = (unsigned long)fsp;

Expand Down
2 changes: 0 additions & 2 deletions include/scsi/libfc.h
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ struct fc_seq_els_data {
* struct fc_fcp_pkt - FCP request structure (one for each scsi_cmnd request)
* @lp: The associated local port
* @state: The state of the I/O
* @tgt_flags: Target's flags
* @ref_cnt: Reference count
* @scsi_pkt_lock: Lock to protect the SCSI packet (must be taken before the
* host_lock if both are to be held at the same time)
Expand Down Expand Up @@ -298,7 +297,6 @@ struct fc_fcp_pkt {
/* Housekeeping information */
struct fc_lport *lp;
u16 state;
u16 tgt_flags;
atomic_t ref_cnt;
spinlock_t scsi_pkt_lock;

Expand Down

0 comments on commit 05fee64

Please sign in to comment.