Skip to content

Commit

Permalink
sparc32: cleanup code for pci init
Browse files Browse the repository at this point in the history
Move the ifdeffery to a header file to make the logic more
obvious where we decide between PCI or SBUS init

Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sam Ravnborg authored and David S. Miller committed Apr 20, 2011
1 parent db1cdd1 commit 06010fb
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 16 deletions.
12 changes: 9 additions & 3 deletions arch/sparc/include/asm/pcic.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,17 @@ struct linux_pcic {
int pcic_imdim;
};

extern int pcic_probe(void);
/* Erm... MJ redefined pcibios_present() so that it does not work early. */
#ifdef CONFIG_PCI
extern int pcic_present(void);
extern int pcic_probe(void);
extern void pci_time_init(void);
extern void sun4m_pci_init_IRQ(void);

#else
static inline int pcic_present(void) { return 0; }
static inline int pcic_probe(void) { return 0; }
static inline void pci_time_init(void) {}
static inline void sun4m_pci_init_IRQ(void) {}
#endif
#endif

/* Size of PCI I/O space which we relocate. */
Expand Down
9 changes: 3 additions & 6 deletions arch/sparc/kernel/irq_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -607,14 +607,11 @@ void __init init_IRQ(void)
break;

case sun4m:
#ifdef CONFIG_PCI
pcic_probe();
if (pcic_present()) {
if (pcic_present())
sun4m_pci_init_IRQ();
break;
}
#endif
sun4m_init_IRQ();
else
sun4m_init_IRQ();
break;

case sun4d:
Expand Down
10 changes: 3 additions & 7 deletions arch/sparc/kernel/time_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -228,14 +228,10 @@ static void __init sbus_time_init(void)

void __init time_init(void)
{
#ifdef CONFIG_PCI
extern void pci_time_init(void);
if (pcic_present()) {
if (pcic_present())
pci_time_init();
return;
}
#endif
sbus_time_init();
else
sbus_time_init();
}


Expand Down

0 comments on commit 06010fb

Please sign in to comment.