Skip to content

Commit

Permalink
staging: comedi: dyna_pci10xx: store the pci_dev in the comedi_device
Browse files Browse the repository at this point in the history
Use the hw_dev pointer in the comedi_device struct to hold the
pci_dev instead of carrying it in the private data.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent b694c4f commit 0618302
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/staging/comedi/drivers/dyna_pci10xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,7 @@ static const struct boardtype boardtypes[] = {
};

struct dyna_pci10xx_private {
struct pci_dev *pci_dev; /* ptr to PCI device */
struct mutex mutex;

/* device base address registers */
unsigned long BADR3;
};

Expand Down Expand Up @@ -273,7 +270,7 @@ static int dyna_pci10xx_attach(struct comedi_device *dev,
pcidev = dyna_pci10xx_find_pci_dev(dev, it);
if (!pcidev)
return -EIO;
devpriv->pci_dev = pcidev;
comedi_set_hw_dev(dev, &pcidev->dev);

dev->board_name = thisboard->name;
dev->irq = 0;
Expand Down Expand Up @@ -344,9 +341,12 @@ static int dyna_pci10xx_attach(struct comedi_device *dev,

static void dyna_pci10xx_detach(struct comedi_device *dev)
{
if (devpriv && devpriv->pci_dev) {
comedi_pci_disable(devpriv->pci_dev);
struct pci_dev *pcidev = comedi_to_pci_dev(dev);

if (devpriv)
mutex_destroy(&devpriv->mutex);
if (pcidev) {
comedi_pci_disable(pcidev);
}
}

Expand Down

0 comments on commit 0618302

Please sign in to comment.