Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 145747
b: refs/heads/master
c: afd9fce
h: refs/heads/master
i:
  145745: 9f14cab
  145743: fb15107
v: v3
  • Loading branch information
Andreas Herrmann authored and Ingo Molnar committed Apr 10, 2009
1 parent 7175313 commit 065f13f
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 35 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 845d8c761ec763871936c62b837c4a9ea6d0fbdb
refs/heads/master: afd9fceec55225d33be878927056a548c2eef26c
8 changes: 8 additions & 0 deletions trunk/arch/x86/include/asm/k8.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,12 @@ extern int cache_k8_northbridges(void);
extern void k8_flush_garts(void);
extern int k8_scan_nodes(unsigned long start, unsigned long end);

#ifdef CONFIG_K8_NB
#define node_to_k8_nb_misc(node) \
(node < num_k8_northbridges) ? k8_northbridges[node] : NULL
#else
#define node_to_k8_nb_misc(node) NULL
#endif


#endif /* _ASM_X86_K8_H */
37 changes: 3 additions & 34 deletions trunk/arch/x86/kernel/cpu/intel_cacheinfo.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

#include <asm/processor.h>
#include <asm/smp.h>
#include <asm/k8.h>

#define LVL_1_INST 1
#define LVL_1_DATA 2
Expand Down Expand Up @@ -159,14 +160,6 @@ struct _cpuid4_info_regs {
unsigned long can_disable;
};

#if defined(CONFIG_PCI) && defined(CONFIG_SYSFS)
static struct pci_device_id k8_nb_id[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x1103) },
{ PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x1203) },
{}
};
#endif

unsigned short num_cache_leaves;

/* AMD doesn't have CPUID4. Emulate it here to report the same
Expand Down Expand Up @@ -704,30 +697,6 @@ static ssize_t show_type(struct _cpuid4_info *this_leaf, char *buf)
#define to_object(k) container_of(k, struct _index_kobject, kobj)
#define to_attr(a) container_of(a, struct _cache_attr, attr)

#ifdef CONFIG_PCI
static struct pci_dev *get_k8_northbridge(int node)
{
struct pci_dev *dev = NULL;
int i;

for (i = 0; i <= node; i++) {
do {
dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev);
if (!dev)
break;
} while (!pci_match_id(&k8_nb_id[0], dev));
if (!dev)
break;
}
return dev;
}
#else
static struct pci_dev *get_k8_northbridge(int node)
{
return NULL;
}
#endif

static ssize_t show_cache_disable(struct _cpuid4_info *this_leaf, char *buf)
{
const struct cpumask *mask = to_cpumask(this_leaf->shared_cpu_map);
Expand All @@ -739,7 +708,7 @@ static ssize_t show_cache_disable(struct _cpuid4_info *this_leaf, char *buf)
if (!this_leaf->can_disable)
return sprintf(buf, "Feature not enabled\n");

dev = get_k8_northbridge(node);
dev = node_to_k8_nb_misc(node);
if (!dev) {
printk(KERN_ERR "Attempting AMD northbridge operation on a system with no northbridge\n");
return -EINVAL;
Expand Down Expand Up @@ -783,7 +752,7 @@ store_cache_disable(struct _cpuid4_info *this_leaf, const char *buf,
return -EINVAL;

val |= 0xc0000000;
dev = get_k8_northbridge(node);
dev = node_to_k8_nb_misc(node);
if (!dev) {
printk(KERN_ERR "Attempting AMD northbridge operation on a system with no northbridge\n");
return -EINVAL;
Expand Down

0 comments on commit 065f13f

Please sign in to comment.