Skip to content

Commit

Permalink
perf tools: Remove usage of trace_sched_wakeup(.success)
Browse files Browse the repository at this point in the history
trace_sched_wakeup(.success) is a dead argument and has been for ages,
the only reason its still there is because of brain dead software, which
apparently includes perf tools

There's a few more instances in pearly snake shit, but that's not
supported as far as I care anyhow, so let that bitrot.

Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20140512181946.GG13467@laptop.programming.kicks-ass.net
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
  • Loading branch information
Peter Zijlstra authored and Jiri Olsa committed May 12, 2014
1 parent 26f2738 commit 0680ee7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
7 changes: 1 addition & 6 deletions tools/perf/builtin-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1007,17 +1007,12 @@ static int latency_wakeup_event(struct perf_sched *sched,
struct perf_sample *sample,
struct machine *machine)
{
const u32 pid = perf_evsel__intval(evsel, sample, "pid"),
success = perf_evsel__intval(evsel, sample, "success");
const u32 pid = perf_evsel__intval(evsel, sample, "pid");
struct work_atoms *atoms;
struct work_atom *atom;
struct thread *wakee;
u64 timestamp = sample->time;

/* Note for later, it may be interesting to observe the failing cases */
if (!success)
return 0;

wakee = machine__findnew_thread(machine, 0, pid);
atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid);
if (!atoms) {
Expand Down
3 changes: 0 additions & 3 deletions tools/perf/tests/evsel-tp-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,6 @@ int test__perf_evsel__tp_sched_test(void)
if (perf_evsel__test_field(evsel, "prio", 4, true))
ret = -1;

if (perf_evsel__test_field(evsel, "success", 4, true))
ret = -1;

if (perf_evsel__test_field(evsel, "target_cpu", 4, true))
ret = -1;

Expand Down

0 comments on commit 0680ee7

Please sign in to comment.