Skip to content

Commit

Permalink
staging: comedi: rti800: tidy up rti800_ao_insn_read()
Browse files Browse the repository at this point in the history
For aesthetic reasons, tidy up the parameters passed to this function.

The comedi core expects (*insn_read) functions to return the number
of data values actually read (insn->n). Change the return to make
clearer.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Apr 9, 2013
1 parent 853fc89 commit 0682323
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/staging/comedi/drivers/rti800.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,16 +219,17 @@ static int rti800_ai_insn_read(struct comedi_device *dev,

static int rti800_ao_insn_read(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data)
struct comedi_insn *insn,
unsigned int *data)
{
struct rti800_private *devpriv = dev->private;
int i;
int chan = CR_CHAN(insn->chanspec);
int i;

for (i = 0; i < insn->n; i++)
data[i] = devpriv->ao_readback[chan];

return i;
return insn->n;
}

static int rti800_ao_insn_write(struct comedi_device *dev,
Expand Down

0 comments on commit 0682323

Please sign in to comment.