Skip to content

Commit

Permalink
x25: bit and/or confusion in x25_ioctl()?
Browse files Browse the repository at this point in the history
Looking at commit ebc3f64 it appears that this was intended
and not the original, equivalent to `if (facilities.reverse & ~0x81)'.

In x25_parse_facilities() that patch changed how facilities->reverse
was set. No other bits were set than 0x80 and/or 0x01.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
roel kluin authored and David S. Miller committed Oct 13, 2009
1 parent f14d42f commit 06a96b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/x25/af_x25.c
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ static int x25_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg)
facilities.throughput > 0xDD)
break;
if (facilities.reverse &&
(facilities.reverse | 0x81)!= 0x81)
(facilities.reverse & 0x81) != 0x81)
break;
x25->facilities = facilities;
rc = 0;
Expand Down

0 comments on commit 06a96b3

Please sign in to comment.