Skip to content

Commit

Permalink
wl1251: Send null data packet with "TODS" bit set
Browse files Browse the repository at this point in the history
According to IEEE80211 standard all the data packets have to be sent with
TODS bit set. This patch fixes the null data packet format which was sent
without TODS bit set. This should fix many problems associated with
power save. Janne Ylalehto also found this fix in the same time as mine,
for a different bug he was working on.

Signed-off-by: Vidhya Govindan <vidhya.govindan@nokia.com>
Reviewed-by: Janne Ylalehto <janne.ylalehto@nokia.com>
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Vidhya Govindan authored and John W. Linville committed Nov 18, 2009
1 parent 79553f8 commit 06cc5d3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/wireless/wl12xx/wl1251_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,8 @@ static int wl1251_build_null_data(struct wl1251 *wl)

memcpy(template.header.sa, wl->mac_addr, ETH_ALEN);
template.header.frame_ctl = cpu_to_le16(IEEE80211_FTYPE_DATA |
IEEE80211_STYPE_NULLFUNC);
IEEE80211_STYPE_NULLFUNC |
IEEE80211_FCTL_TODS);

return wl1251_cmd_template_set(wl, CMD_NULL_DATA, &template,
sizeof(template));
Expand Down

0 comments on commit 06cc5d3

Please sign in to comment.