Skip to content

Commit

Permalink
target/iscsi: Don't log "iSCSI Login negotiation failed." twice
Browse files Browse the repository at this point in the history
There's no need for iscsi_target_init_negotiation() to print

    iSCSI Login negotiation failed.

on failure, since its only caller (__iscsi_target_login_thread())
prints exactly the same message if it gets an error return back.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
  • Loading branch information
Roland Dreier authored and Nicholas Bellinger committed Sep 18, 2012
1 parent fd30e93 commit 06cda52
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/target/iscsi/iscsi_target_nego.c
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,6 @@ struct iscsi_login *iscsi_target_init_negotiation(
* Locates Target Portal from NP -> Target IQN
*/
if (iscsi_target_locate_portal(np, conn, login) < 0) {
pr_err("iSCSI Login negotiation failed.\n");
goto out;
}

Expand Down

0 comments on commit 06cda52

Please sign in to comment.