Skip to content

Commit

Permalink
xircom_cb should return NETDEV_TX_BUSY when no descriptors available
Browse files Browse the repository at this point in the history
Changes in other networking paths uncovered a bug in the xircom_cb
driver which made the kernel spew lots of the following error messages:

  BUG eth1 code -5 qlen 0

It turned out that the driver returned -EIO when there was no
descriptor available for sending packets. It should return
NETDEV_TX_BUSY instead. This was discussed on the netdev list before,
see http://thread.gmane.org/gmane.linux.network/84603 .

Signed-off-by: Erik Mouw <mouw@nl.linux.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Erik Mouw authored and Jeff Garzik committed Feb 5, 2008
1 parent 6c04a51 commit 06f7525
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/tulip/xircom_cb.c
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ static int xircom_start_xmit(struct sk_buff *skb, struct net_device *dev)
spin_unlock_irqrestore(&card->lock,flags);
trigger_transmit(card);

return -EIO;
return NETDEV_TX_BUSY;
}


Expand Down

0 comments on commit 06f7525

Please sign in to comment.