Skip to content

Commit

Permalink
[CIFS] Change pragma pack(1) to attribute(packed) to allow cifs on ar…
Browse files Browse the repository at this point in the history
…m to access

unaligned structures coming in off the wire

gcc on arm processors generates very odd code with pragma pack specified -
although it does pack the structures in some sense - it does not allow you
to access unaligned elements in nested structures at the right offset as other
architectures do.  Oddly enough though, specifying the structures as packed
the long way - one by one with the packed attribute does work.  Rather than
fighting over whether this is a gcc bug or some obscure side effect
of pragma pack, it is easier to do what most (all but 96 other places in
the kernel) do - and replace pragma pack with dozens of attribute(packed)
structure qualifiers.  Much more verbose ... but at least it works.

Signed-off-by: David Kleikamp <shaggy@austin.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>  CG: -----------------------------------------------------------------------
  • Loading branch information
Steve French committed Oct 27, 2005
1 parent 0429094 commit 0753ca7
Show file tree
Hide file tree
Showing 3 changed files with 182 additions and 186 deletions.
Loading

0 comments on commit 0753ca7

Please sign in to comment.