Skip to content

Commit

Permalink
GFS2: Combine functions gfs2_glock_wait and wait_on_holder
Browse files Browse the repository at this point in the history
Function gfs2_glock_wait only called function wait_on_holder and
returned its return code, so they were combined for readability.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Bob Peterson authored and Steven Whitehouse committed Sep 24, 2012
1 parent 4abb6ad commit 07a7904
Showing 1 changed file with 9 additions and 14 deletions.
23 changes: 9 additions & 14 deletions fs/gfs2/glock.c
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,14 @@ static int gfs2_glock_demote_wait(void *word)
return 0;
}

static void wait_on_holder(struct gfs2_holder *gh)
/**
* gfs2_glock_wait - wait on a glock acquisition
* @gh: the glock holder
*
* Returns: 0 on success
*/

int gfs2_glock_wait(struct gfs2_holder *gh)
{
unsigned long time1 = jiffies;

Expand All @@ -880,6 +887,7 @@ static void wait_on_holder(struct gfs2_holder *gh)
gh->gh_gl->gl_hold_time = min(gh->gh_gl->gl_hold_time +
GL_GLOCK_HOLD_INCR,
GL_GLOCK_MAX_HOLD);
return gh->gh_error;
}

static void wait_on_demote(struct gfs2_glock *gl)
Expand Down Expand Up @@ -915,19 +923,6 @@ static void handle_callback(struct gfs2_glock *gl, unsigned int state,
trace_gfs2_demote_rq(gl);
}

/**
* gfs2_glock_wait - wait on a glock acquisition
* @gh: the glock holder
*
* Returns: 0 on success
*/

int gfs2_glock_wait(struct gfs2_holder *gh)
{
wait_on_holder(gh);
return gh->gh_error;
}

void gfs2_print_dbg(struct seq_file *seq, const char *fmt, ...)
{
struct va_format vaf;
Expand Down

0 comments on commit 07a7904

Please sign in to comment.