Skip to content

Commit

Permalink
staging: gdm72xx: use kzalloc to allocate usb_tx structure
Browse files Browse the repository at this point in the history
the code under alloc_tx_struct does the allocation of usb_tx structure
using kmalloc, and memsets the allocated pointer, instead we can
directly use kzalloc so that the allocated memory is set with
zeros

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Sep 4, 2012
1 parent 8f8b77b commit 07ad99c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions drivers/staging/gdm72xx/gdm_sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,10 @@ static struct sdio_tx *alloc_tx_struct(struct tx_cxt *tx)
{
struct sdio_tx *t = NULL;

t = kmalloc(sizeof(*t), GFP_ATOMIC);
t = kzalloc(sizeof(*t), GFP_ATOMIC);
if (t == NULL)
goto out;

memset(t, 0, sizeof(*t));

t->buf = kmalloc(TX_BUF_SIZE, GFP_ATOMIC);
if (t->buf == NULL)
goto out;
Expand Down
4 changes: 1 addition & 3 deletions drivers/staging/gdm72xx/gdm_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,10 @@ static struct usb_tx *alloc_tx_struct(struct tx_cxt *tx)
{
struct usb_tx *t = NULL;

t = kmalloc(sizeof(*t), GFP_ATOMIC);
t = kzalloc(sizeof(*t), GFP_ATOMIC);
if (t == NULL)
goto out;

memset(t, 0, sizeof(*t));

t->urb = usb_alloc_urb(0, GFP_ATOMIC);
t->buf = kmalloc(TX_BUF_SIZE, GFP_ATOMIC);
if (t->urb == NULL || t->buf == NULL)
Expand Down

0 comments on commit 07ad99c

Please sign in to comment.