Skip to content

Commit

Permalink
[SCSI] zfcp: Remove qtcb dump to kernel log
Browse files Browse the repository at this point in the history
Is not appropriate to printk() tons of hardware trace data.

Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
  • Loading branch information
Martin Peschke authored and James Bottomley committed Apr 7, 2008
1 parent 0f65e95 commit 07c70d2
Showing 1 changed file with 0 additions and 31 deletions.
31 changes: 0 additions & 31 deletions drivers/s390/scsi/zfcp_fsf.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,37 +284,6 @@ zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *fsf_req)
goto skip_protstatus;
}

/* log additional information provided by FSF (if any) */
if (likely(qtcb->header.log_length)) {
/* do not trust them ;-) */
if (unlikely(qtcb->header.log_start >
sizeof(struct fsf_qtcb))) {
ZFCP_LOG_NORMAL
("bug: ULP (FSF logging) log data starts "
"beyond end of packet header. Ignored. "
"(start=%i, size=%li)\n",
qtcb->header.log_start,
sizeof(struct fsf_qtcb));
goto forget_log;
}
if (unlikely((size_t) (qtcb->header.log_start +
qtcb->header.log_length) >
sizeof(struct fsf_qtcb))) {
ZFCP_LOG_NORMAL("bug: ULP (FSF logging) log data ends "
"beyond end of packet header. Ignored. "
"(start=%i, length=%i, size=%li)\n",
qtcb->header.log_start,
qtcb->header.log_length,
sizeof(struct fsf_qtcb));
goto forget_log;
}
ZFCP_LOG_TRACE("ULP log data: \n");
ZFCP_HEX_DUMP(ZFCP_LOG_LEVEL_TRACE,
(char *) qtcb + qtcb->header.log_start,
qtcb->header.log_length);
}
forget_log:

/* evaluate FSF Protocol Status */
switch (qtcb->prefix.prot_status) {

Expand Down

0 comments on commit 07c70d2

Please sign in to comment.