Skip to content

Commit

Permalink
ceph: remove bogus mds forward warning
Browse files Browse the repository at this point in the history
The must_resend flag is always true, not false.  In any case, we can
just ignore it anyway.

Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Sage Weil committed Feb 26, 2010
1 parent c99eb1c commit 080af17
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions fs/ceph/mds_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1899,22 +1899,18 @@ static void handle_forward(struct ceph_mds_client *mdsc,
u64 tid = le64_to_cpu(msg->hdr.tid);
u32 next_mds;
u32 fwd_seq;
u8 must_resend;
int err = -EINVAL;
void *p = msg->front.iov_base;
void *end = p + msg->front.iov_len;

ceph_decode_need(&p, end, 2*sizeof(u32), bad);
next_mds = ceph_decode_32(&p);
fwd_seq = ceph_decode_32(&p);
must_resend = ceph_decode_8(&p);

WARN_ON(must_resend); /* shouldn't happen. */

mutex_lock(&mdsc->mutex);
req = __lookup_request(mdsc, tid);
if (!req) {
dout("forward %llu dne\n", tid);
dout("forward %llu to mds%d - req dne\n", tid, next_mds);
goto out; /* dup reply? */
}

Expand Down

0 comments on commit 080af17

Please sign in to comment.