Skip to content

Commit

Permalink
USB: io_ti: check firmware version before updating
Browse files Browse the repository at this point in the history
If we can't read the firmware for a device from the disk, and yet the
device already has a valid firmware image in it, we don't want to
replace the firmware with something invalid.  So check the version
number to be less than the current one to verify this is the correct
thing to do.


Reported-by: Chris Beauchamp <chris@chillibean.tv>
Tested-by: Chris Beauchamp <chris@chillibean.tv>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Aug 24, 2010
1 parent d1ab903 commit 0827a9f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/serial/io_ti.c
Original file line number Diff line number Diff line change
Expand Up @@ -1151,7 +1151,7 @@ static int download_fw(struct edgeport_serial *serial)

/* Check if we have an old version in the I2C and
update if necessary */
if (download_cur_ver != download_new_ver) {
if (download_cur_ver < download_new_ver) {
dbg("%s - Update I2C dld from %d.%d to %d.%d",
__func__,
firmware_version->Ver_Major,
Expand Down

0 comments on commit 0827a9f

Please sign in to comment.