Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 213062
b: refs/heads/master
c: 02977e4
h: refs/heads/master
v: v3
  • Loading branch information
Vivek Goyal authored and Jens Axboe committed Oct 1, 2010
1 parent 06eff4a commit 082edea
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 61014e96e6ed55b8db0af31574eec2a75d4e8755
refs/heads/master: 02977e4af7ed3b478c505e50491ffdf3e1314cf4
17 changes: 13 additions & 4 deletions trunk/block/blk-throttle.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ struct throtl_data
unsigned int nr_queued[2];

/*
* number of total undestroyed groups (excluding root group)
* number of total undestroyed groups
*/
unsigned int nr_undestroyed_grps;

Expand Down Expand Up @@ -940,7 +940,17 @@ int blk_throtl_init(struct request_queue *q)
/* Practically unlimited BW */
tg->bps[0] = tg->bps[1] = -1;
tg->iops[0] = tg->iops[1] = -1;
atomic_set(&tg->ref, 1);

/*
* Set root group reference to 2. One reference will be dropped when
* all groups on tg_list are being deleted during queue exit. Other
* reference will remain there as we don't want to delete this group
* as it is statically allocated and gets destroyed when throtl_data
* goes away.
*/
atomic_set(&tg->ref, 2);
hlist_add_head(&tg->tg_node, &td->tg_list);
td->nr_undestroyed_grps++;

INIT_DELAYED_WORK(&td->throtl_work, blk_throtl_work);

Expand All @@ -966,10 +976,9 @@ void blk_throtl_exit(struct request_queue *q)

spin_lock_irq(q->queue_lock);
throtl_release_tgs(td);
blkiocg_del_blkio_group(&td->root_tg.blkg);

/* If there are other groups */
if (td->nr_undestroyed_grps >= 1)
if (td->nr_undestroyed_grps > 0)
wait = true;

spin_unlock_irq(q->queue_lock);
Expand Down

0 comments on commit 082edea

Please sign in to comment.