Skip to content

Commit

Permalink
[S390] cio: Use helpers instead of container_of().
Browse files Browse the repository at this point in the history
- Introduce to_cssdriver.
- Use to_xxx instead of container_of where possible.

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Cornelia Huck authored and Martin Schwidefsky committed Jan 26, 2008
1 parent 14ff56b commit 084325d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
4 changes: 2 additions & 2 deletions drivers/s390/cio/ccwgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ ccwgroup_bus_match (struct device * dev, struct device_driver * drv)
struct ccwgroup_device *gdev;
struct ccwgroup_driver *gdrv;

gdev = container_of(dev, struct ccwgroup_device, dev);
gdrv = container_of(drv, struct ccwgroup_driver, driver);
gdev = to_ccwgroupdev(dev);
gdrv = to_ccwgroupdrv(drv);

if (gdev->creator_id == gdrv->driver_id)
return 1;
Expand Down
6 changes: 3 additions & 3 deletions drivers/s390/cio/css.c
Original file line number Diff line number Diff line change
Expand Up @@ -787,8 +787,8 @@ int sch_is_pseudo_sch(struct subchannel *sch)
static int
css_bus_match (struct device *dev, struct device_driver *drv)
{
struct subchannel *sch = container_of (dev, struct subchannel, dev);
struct css_driver *driver = container_of (drv, struct css_driver, drv);
struct subchannel *sch = to_subchannel(dev);
struct css_driver *driver = to_cssdriver(drv);

if (sch->st == driver->subchannel_type)
return 1;
Expand All @@ -802,7 +802,7 @@ css_probe (struct device *dev)
struct subchannel *sch;

sch = to_subchannel(dev);
sch->driver = container_of (dev->driver, struct css_driver, drv);
sch->driver = to_cssdriver(dev->driver);
return (sch->driver->probe ? sch->driver->probe(sch) : 0);
}

Expand Down
2 changes: 2 additions & 0 deletions drivers/s390/cio/css.h
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ struct css_driver {
void (*shutdown)(struct subchannel *);
};

#define to_cssdriver(n) container_of(n, struct css_driver, drv)

/*
* all css_drivers have the css_bus_type
*/
Expand Down

0 comments on commit 084325d

Please sign in to comment.