Skip to content

Commit

Permalink
bnx2x: Move to D0 before clearing MSI/MSI-X configuration.
Browse files Browse the repository at this point in the history
Move to D0 before clearing MSI/MSI-X configuration. Otherwise MSI/MSI-X
won't be cleared.

Signed-off-by: Vladislav Zolotarov <vladz@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vladislav Zolotarov authored and David S. Miller committed Jan 9, 2011
1 parent 4a33bc0 commit 084d6cb
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions drivers/net/bnx2x/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -9508,9 +9508,15 @@ static void __devexit bnx2x_remove_one(struct pci_dev *pdev)
/* Delete all NAPI objects */
bnx2x_del_all_napi(bp);

/* Power on: we can't let PCI layer write to us while we are in D3 */
bnx2x_set_power_state(bp, PCI_D0);

/* Disable MSI/MSI-X */
bnx2x_disable_msi(bp);

/* Power off */
bnx2x_set_power_state(bp, PCI_D3hot);

/* Make sure RESET task is not scheduled before continuing */
cancel_delayed_work_sync(&bp->reset_task);

Expand Down

0 comments on commit 084d6cb

Please sign in to comment.