Skip to content

Commit

Permalink
mtd: remove printk's for [kv][mz]alloc failures
Browse files Browse the repository at this point in the history
When a memory allocation fails, the kernel will print out a backtrace
automatically. These print statements are unnecessary.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
  • Loading branch information
Brian Norris authored and Artem Bityutskiy committed Sep 11, 2011
1 parent 9616605 commit 0870066
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 31 deletions.
3 changes: 0 additions & 3 deletions drivers/mtd/cmdlinepart.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,7 @@ static struct mtd_partition * newpart(char *s,
extra_mem_size;
parts = kzalloc(alloc_size, GFP_KERNEL);
if (!parts)
{
printk(KERN_ERR ERRP "out of memory\n");
return NULL;
}
extra_mem = (unsigned char *)(parts + *num_parts);
}
/* enter this partition (offset will be calculated later if it is zero at this point) */
Expand Down
4 changes: 1 addition & 3 deletions drivers/mtd/inftlcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ static void inftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)

inftl = kzalloc(sizeof(*inftl), GFP_KERNEL);

if (!inftl) {
printk(KERN_WARNING "INFTL: Out of memory for data structures\n");
if (!inftl)
return;
}

inftl->mbd.mtd = mtd;
inftl->mbd.devnum = -1;
Expand Down
13 changes: 3 additions & 10 deletions drivers/mtd/nand/nand_bbt.c
Original file line number Diff line number Diff line change
Expand Up @@ -1121,10 +1121,8 @@ int nand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
* table.
*/
this->bbt = kzalloc(len, GFP_KERNEL);
if (!this->bbt) {
printk(KERN_ERR "nand_scan_bbt: Out of memory\n");
if (!this->bbt)
return -ENOMEM;
}

/*
* If no primary table decriptor is given, scan the device to build a
Expand All @@ -1146,7 +1144,6 @@ int nand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
len += (len >> this->page_shift) * mtd->oobsize;
buf = vmalloc(len);
if (!buf) {
printk(KERN_ERR "nand_bbt: Out of memory\n");
kfree(this->bbt);
this->bbt = NULL;
return -ENOMEM;
Expand Down Expand Up @@ -1195,10 +1192,8 @@ int nand_update_bbt(struct mtd_info *mtd, loff_t offs)
len = (1 << this->bbt_erase_shift);
len += (len >> this->page_shift) * mtd->oobsize;
buf = kmalloc(len, GFP_KERNEL);
if (!buf) {
printk(KERN_ERR "nand_update_bbt: Out of memory\n");
if (!buf)
return -ENOMEM;
}

writeops = md != NULL ? 0x03 : 0x01;

Expand Down Expand Up @@ -1307,10 +1302,8 @@ static int nand_create_default_bbt_descr(struct nand_chip *this)
return -EINVAL;
}
bd = kzalloc(sizeof(*bd), GFP_KERNEL);
if (!bd) {
printk(KERN_ERR "nand_create_default_bbt_descr: Out of memory\n");
if (!bd)
return -ENOMEM;
}
bd->options = this->bbt_options;
bd->offs = this->badblockpos;
bd->len = (this->options & NAND_BUSWIDTH_16) ? 2 : 1;
Expand Down
1 change: 0 additions & 1 deletion drivers/mtd/nand/rtc_from4.c
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,6 @@ static int rtc_from4_errstat(struct mtd_info *mtd, struct nand_chip *this,
len = mtd->writesize;
buf = kmalloc(len, GFP_KERNEL);
if (!buf) {
printk(KERN_ERR "rtc_from4_errstat: Out of memory!\n");
er_stat = 1;
goto out;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/mtd/nftlcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,8 @@ static void nftl_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)

nftl = kzalloc(sizeof(struct NFTLrecord), GFP_KERNEL);

if (!nftl) {
printk(KERN_WARNING "NFTL: out of memory for data structures\n");
if (!nftl)
return;
}

nftl->mbd.mtd = mtd;
nftl->mbd.devnum = -1;
Expand Down
4 changes: 1 addition & 3 deletions drivers/mtd/onenand/onenand_bbt.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,8 @@ int onenand_scan_bbt(struct mtd_info *mtd, struct nand_bbt_descr *bd)
len = this->chipsize >> (this->erase_shift + 2);
/* Allocate memory (2bit per block) and clear the memory bad block table */
bbm->bbt = kzalloc(len, GFP_KERNEL);
if (!bbm->bbt) {
printk(KERN_ERR "onenand_scan_bbt: Out of memory\n");
if (!bbm->bbt)
return -ENOMEM;
}

/* Set the bad block position */
bbm->badblockpos = ONENAND_BADBLOCK_POS;
Expand Down
10 changes: 2 additions & 8 deletions drivers/mtd/ssfdc.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,11 +304,8 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
return;

ssfdc = kzalloc(sizeof(struct ssfdcr_record), GFP_KERNEL);
if (!ssfdc) {
printk(KERN_WARNING
"SSFDC_RO: out of memory for data structures\n");
if (!ssfdc)
return;
}

ssfdc->mbd.mtd = mtd;
ssfdc->mbd.devnum = -1;
Expand Down Expand Up @@ -342,11 +339,8 @@ static void ssfdcr_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
/* Allocate logical block map */
ssfdc->logic_block_map = kmalloc(sizeof(ssfdc->logic_block_map[0]) *
ssfdc->map_len, GFP_KERNEL);
if (!ssfdc->logic_block_map) {
printk(KERN_WARNING
"SSFDC_RO: out of memory for data structures\n");
if (!ssfdc->logic_block_map)
goto out_err;
}
memset(ssfdc->logic_block_map, 0xff, sizeof(ssfdc->logic_block_map[0]) *
ssfdc->map_len);

Expand Down

0 comments on commit 0870066

Please sign in to comment.