Skip to content

Commit

Permalink
genirq: Use handle_irq_event() in the spurious poll code
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Thomas Gleixner committed Feb 19, 2011
1 parent 849f061 commit 0877d66
Showing 1 changed file with 9 additions and 12 deletions.
21 changes: 9 additions & 12 deletions kernel/irq/spurious.c
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,14 @@ bool irq_wait_for_poll(struct irq_desc *desc)
#endif
}


/*
* Recovery handler for misrouted interrupts.
*/
static int try_one_irq(int irq, struct irq_desc *desc, bool force)
{
irqreturn_t ret = IRQ_NONE;
struct irqaction *action;
int ok = 0;

raw_spin_lock(&desc->lock);

Expand Down Expand Up @@ -96,21 +97,17 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force)
goto out;
}

/* Honour the normal IRQ locking and mark it poll in progress */
desc->status |= IRQ_INPROGRESS | IRQ_POLL_INPROGRESS;
/* Mark it poll in progress */
desc->status |= IRQ_POLL_INPROGRESS;
do {
desc->status &= ~IRQ_PENDING;
raw_spin_unlock(&desc->lock);
if (handle_IRQ_event(irq, action) != IRQ_NONE)
ok = 1;
raw_spin_lock(&desc->lock);
if (handle_irq_event(desc) == IRQ_HANDLED)
ret = IRQ_HANDLED;
action = desc->action;
} while ((desc->status & IRQ_PENDING) && action);

desc->status &= ~(IRQ_INPROGRESS | IRQ_POLL_INPROGRESS);
} while ((desc->status & IRQ_PENDING) && action);
desc->status &= ~IRQ_POLL_INPROGRESS;
out:
raw_spin_unlock(&desc->lock);
return ok;
return ret == IRQ_HANDLED;
}

static int misrouted_irq(int irq)
Expand Down

0 comments on commit 0877d66

Please sign in to comment.