Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 214437
b: refs/heads/master
c: f3c6808
h: refs/heads/master
i:
  214435: 69651d0
v: v3
  • Loading branch information
Zach Brown authored and Andy Grover committed Sep 9, 2010
1 parent 05b63a0 commit 087d08c
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 15 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 3e0249f9c05cb77b66f7f09644ca9ca208d991a9
refs/heads/master: f3c6808d3d8513db2b0543538fc35c25a60fe7a7
12 changes: 12 additions & 0 deletions trunk/net/rds/connection.c
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,18 @@ void rds_conn_drop(struct rds_connection *conn)
}
EXPORT_SYMBOL_GPL(rds_conn_drop);

/*
* If the connection is down, trigger a connect. We may have scheduled a
* delayed reconnect however - in this case we should not interfere.
*/
void rds_conn_connect_if_down(struct rds_connection *conn)
{
if (rds_conn_state(conn) == RDS_CONN_DOWN &&
!test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags))
queue_delayed_work(rds_wq, &conn->c_conn_w, 0);
}
EXPORT_SYMBOL_GPL(rds_conn_connect_if_down);

/*
* An error occurred on the connection
*/
Expand Down
1 change: 1 addition & 0 deletions trunk/net/rds/rds.h
Original file line number Diff line number Diff line change
Expand Up @@ -617,6 +617,7 @@ void rds_conn_shutdown(struct rds_connection *conn);
void rds_conn_destroy(struct rds_connection *conn);
void rds_conn_reset(struct rds_connection *conn);
void rds_conn_drop(struct rds_connection *conn);
void rds_conn_connect_if_down(struct rds_connection *conn);
void rds_for_each_conn_info(struct socket *sock, unsigned int len,
struct rds_info_iterator *iter,
struct rds_info_lengths *lens,
Expand Down
16 changes: 2 additions & 14 deletions trunk/net/rds/send.c
Original file line number Diff line number Diff line change
Expand Up @@ -1036,13 +1036,7 @@ int rds_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr *msg,
goto out;
}

/* If the connection is down, trigger a connect. We may
* have scheduled a delayed reconnect however - in this case
* we should not interfere.
*/
if (rds_conn_state(conn) == RDS_CONN_DOWN &&
!test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags))
queue_delayed_work(rds_wq, &conn->c_conn_w, 0);
rds_conn_connect_if_down(conn);

ret = rds_cong_wait(conn->c_fcong, dport, nonblock, rs);
if (ret) {
Expand Down Expand Up @@ -1122,13 +1116,7 @@ rds_send_pong(struct rds_connection *conn, __be16 dport)
rm->m_daddr = conn->c_faddr;
rm->data.op_active = 1;

/* If the connection is down, trigger a connect. We may
* have scheduled a delayed reconnect however - in this case
* we should not interfere.
*/
if (rds_conn_state(conn) == RDS_CONN_DOWN &&
!test_and_set_bit(RDS_RECONNECT_PENDING, &conn->c_flags))
queue_delayed_work(rds_wq, &conn->c_conn_w, 0);
rds_conn_connect_if_down(conn);

ret = rds_cong_wait(conn->c_fcong, dport, 1, NULL);
if (ret)
Expand Down

0 comments on commit 087d08c

Please sign in to comment.