Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 364535
b: refs/heads/master
c: f07bd56
h: refs/heads/master
i:
  364533: 3654751
  364531: 05210c0
  364527: a609434
v: v3
  • Loading branch information
Felipe Balbi committed Mar 18, 2013
1 parent 1b77714 commit 087d618
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 7eaf8f2a7da6506df0e6edc4fdb22678f0eb3602
refs/heads/master: f07bd56bbdaa2340ebf46af9a37e7b2d1b4578e3
23 changes: 19 additions & 4 deletions trunk/drivers/usb/gadget/udc-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,22 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget)
if (!udc)
goto err1;

if (gadget->register_my_device) {
dev_set_name(&gadget->dev, "gadget");

ret = device_register(&gadget->dev);
if (ret)
goto err2;
}

device_initialize(&udc->dev);
udc->dev.release = usb_udc_release;
udc->dev.class = udc_class;
udc->dev.groups = usb_udc_attr_groups;
udc->dev.parent = parent;
ret = dev_set_name(&udc->dev, "%s", kobject_name(&parent->kobj));
if (ret)
goto err2;
goto err3;

udc->gadget = gadget;

Expand All @@ -189,18 +197,22 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget)

ret = device_add(&udc->dev);
if (ret)
goto err3;
goto err4;

mutex_unlock(&udc_lock);

return 0;
err3:

err4:
list_del(&udc->list);
mutex_unlock(&udc_lock);

err2:
err3:
put_device(&udc->dev);

err2:
if (gadget->register_my_device)
put_device(&gadget->dev);
err1:
return ret;
}
Expand Down Expand Up @@ -254,6 +266,9 @@ void usb_del_gadget_udc(struct usb_gadget *gadget)

kobject_uevent(&udc->dev.kobj, KOBJ_REMOVE);
device_unregister(&udc->dev);

if (gadget->register_my_device)
device_unregister(&gadget->dev);
}
EXPORT_SYMBOL_GPL(usb_del_gadget_udc);

Expand Down
4 changes: 4 additions & 0 deletions trunk/include/linux/usb/gadget.h
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,9 @@ struct usb_gadget_ops {
* only supports HNP on a different root port.
* @b_hnp_enable: OTG device feature flag, indicating that the A-Host
* enabled HNP support.
* @register_my_device: Flag telling udc-core that UDC driver didn't
* register the gadget device to the driver model. Temporary until
* all UDC drivers are fixed up properly.
* @name: Identifies the controller hardware type. Used in diagnostics
* and sometimes configuration.
* @dev: Driver model state for this abstract device.
Expand Down Expand Up @@ -531,6 +534,7 @@ struct usb_gadget {
unsigned b_hnp_enable:1;
unsigned a_hnp_support:1;
unsigned a_alt_hnp_support:1;
unsigned register_my_device:1;
const char *name;
struct device dev;
unsigned out_epnum;
Expand Down

0 comments on commit 087d618

Please sign in to comment.