Skip to content

Commit

Permalink
ftrace: pipe fixes
Browse files Browse the repository at this point in the history
Some fixes for better output with the trace pipe.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Steven Rostedt authored and Thomas Gleixner committed May 23, 2008
1 parent dcb6308 commit 088b1e4
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions kernel/trace/trace.c
Original file line number Diff line number Diff line change
Expand Up @@ -770,11 +770,6 @@ trace_entry_idx(struct trace_array *tr, struct trace_array_cpu *data,

array = page_address(page);

/* Still possible to catch up to the tail */
if (iter->next_idx[cpu] && array == data->trace_tail &&
iter->next_page_idx[cpu] == data->trace_tail_idx)
return NULL;

WARN_ON(iter->next_page_idx[cpu] >= ENTRIES_PER_PAGE);
return &array[iter->next_page_idx[cpu]];
}
Expand Down Expand Up @@ -1921,7 +1916,6 @@ tracing_read_pipe(struct file *filp, char __user *ubuf,
struct trace_iterator *iter = filp->private_data;
struct trace_array_cpu *data;
static cpumask_t mask;
struct trace_entry *entry;
static int start;
unsigned long flags;
int read = 0;
Expand Down Expand Up @@ -2013,10 +2007,15 @@ tracing_read_pipe(struct file *filp, char __user *ubuf,
cpu_set(cpu, mask);
}

while ((entry = find_next_entry_inc(iter)) != NULL) {
while (find_next_entry_inc(iter) != NULL) {
int len = iter->seq.len;

ret = print_trace_line(iter);
if (!ret)
if (!ret) {
/* don't print partial lines */
iter->seq.len = len;
break;
}

trace_consume(iter);

Expand Down

0 comments on commit 088b1e4

Please sign in to comment.