Skip to content

Commit

Permalink
m68knommu: Don't lose state if sigframe setup fails
Browse files Browse the repository at this point in the history
exact parallel to m68k analog

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
  • Loading branch information
Al Viro authored and Geert Uytterhoeven committed Jan 7, 2011
1 parent d1574df commit 089e449
Showing 1 changed file with 12 additions and 7 deletions.
19 changes: 12 additions & 7 deletions arch/m68knommu/kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,7 @@ get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t frame_size)
return (void *)((usp - frame_size) & -8UL);
}

static void setup_frame (int sig, struct k_sigaction *ka,
static int setup_frame (int sig, struct k_sigaction *ka,
sigset_t *set, struct pt_regs *regs)
{
struct sigframe *frame;
Expand Down Expand Up @@ -582,14 +582,14 @@ static void setup_frame (int sig, struct k_sigaction *ka,
tregs->pc = regs->pc;
tregs->sr = regs->sr;
}
return;
return err;

give_sigsegv:
force_sigsegv(sig, current);
goto adjust_stack;
}

static void setup_rt_frame (int sig, struct k_sigaction *ka, siginfo_t *info,
static int setup_rt_frame (int sig, struct k_sigaction *ka, siginfo_t *info,
sigset_t *set, struct pt_regs *regs)
{
struct rt_sigframe *frame;
Expand Down Expand Up @@ -646,7 +646,7 @@ static void setup_rt_frame (int sig, struct k_sigaction *ka, siginfo_t *info,
tregs->pc = regs->pc;
tregs->sr = regs->sr;
}
return;
return err;

give_sigsegv:
force_sigsegv(sig, current);
Expand Down Expand Up @@ -693,23 +693,29 @@ static void
handle_signal(int sig, struct k_sigaction *ka, siginfo_t *info,
sigset_t *oldset, struct pt_regs *regs)
{
int err;
/* are we from a system call? */
if (regs->orig_d0 >= 0)
/* If so, check system call restarting.. */
handle_restart(regs, ka, 1);

/* set up the stack frame */
if (ka->sa.sa_flags & SA_SIGINFO)
setup_rt_frame(sig, ka, info, oldset, regs);
err = setup_rt_frame(sig, ka, info, oldset, regs);
else
setup_frame(sig, ka, oldset, regs);
err = setup_frame(sig, ka, oldset, regs);

if (err)
return;

spin_lock_irq(&current->sighand->siglock);
sigorsets(&current->blocked,&current->blocked,&ka->sa.sa_mask);
if (!(ka->sa.sa_flags & SA_NODEFER))
sigaddset(&current->blocked,sig);
recalc_sigpending();
spin_unlock_irq(&current->sighand->siglock);

clear_thread_flag(TIF_RESTORE_SIGMASK);
}

/*
Expand Down Expand Up @@ -742,7 +748,6 @@ asmlinkage void do_signal(struct pt_regs *regs)
if (signr > 0) {
/* Whee! Actually deliver the signal. */
handle_signal(signr, &ka, &info, oldset, regs);
clear_thread_flag(TIF_RESTORE_SIGMASK);
return;
}

Expand Down

0 comments on commit 089e449

Please sign in to comment.